acelyc111 commented on code in PR #2184:
URL:
https://github.com/apache/incubator-pegasus/pull/2184#discussion_r1921897760
##########
src/replica/duplication/replica_duplicator.cpp:
##########
@@ -161,7 +161,7 @@ void replica_duplicator::start_dup_log()
_load = std::make_unique<load_mutation>(this, _replica,
_load_private.get());
from(*_load).link(*_ship).link(*_load);
- fork(*_load_private, LPC_REPLICATION_LONG_LOW, 0).link(*_ship);
+ fork(*_load_private, LPC_REPLICATION_LONG_COMMON, 0).link(*_ship);
Review Comment:
The reason of priority set to LPC_REPLICATION_LONG_LOW is to reduce the
impact of duplication on normal read/write operations on the master cluster.
There are some usage scenarios of the duplication, some user cares about the
latency, some cares about the master cluster's thoughput.
How about add a configuration for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]