danischroeter commented on code in PR #4:
URL: https://github.com/apache/incubator-pekko/pull/4#discussion_r1012612248
##########
akka-stream/src/main/scala/akka/stream/impl/Timers.scala:
##########
@@ -275,11 +275,15 @@ import akka.stream.stage._
val now = System.nanoTime()
// Timer is reliably cancelled if a regular element arrives first.
Scheduler rather schedules too late
Review Comment:
we could also remove the entire comment and adapt log.warning to something
like this:
```
log.warning(
s"Timer should have triggered only after deadline but now is
$now and deadline was $nextDeadline diff $diff. (time running backwards?)
Reschedule instead of emitting.")
```
This imho would be clearer to read the code and for the one stumbling upon
this log...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
