danischroeter commented on code in PR #4:
URL: https://github.com/apache/incubator-pekko/pull/4#discussion_r1012637102
##########
akka-stream/src/main/scala/akka/stream/impl/Timers.scala:
##########
@@ -275,11 +275,15 @@ import akka.stream.stage._
val now = System.nanoTime()
// Timer is reliably cancelled if a regular element arrives first.
Scheduler rather schedules too late
// than too early so the deadline must have passed at this time.
- assert(
- now - nextDeadline >= 0,
Review Comment:
There seems to be no clear reason why this happens since ntp is guaranteed
to be monotonic - but we do know that it happens. Therefore I find a warning
log to be appropriate. Users should investigate the cause of it and maybe in
the future we'll have a better way (or maybe a fixed jvm and this does not
happen anymore...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
