Let's look at the contribution and have a bit of a discussion before we vote.
Where does the contribution come from? Is it the same repository that we got the Akka code from? If not, is it a well respected repository not something owned by [email protected]? What licensing is documented with the code? In the file headers? Is the owner of the repository a committer on this project? Are they well known to the dev team? Is there anything wonky in the code base? In the documentation? It is entirely possible we can bring this in without a vote but let's have the discussion. Claude On Wed, Jul 19, 2023 at 3:29 PM Claude Warren, Jr <[email protected]> wrote: > Excluding the .md files the files with unapproved licenses are: > > {noformat} > incubator-pekko/.asf.yaml > incubator-pekko/.git-blame-ignore-revs > incubator-pekko/.gitattributes > incubator-pekko/.gitignore > incubator-pekko/.jvmopts-ci > incubator-pekko/.sbt-java-formatter.conf > incubator-pekko/.sbtopts > incubator-pekko/.scala-steward.conf > incubator-pekko/.scalafix.conf > incubator-pekko/.scalafmt.conf > incubator-pekko/COPYING.protobuf > incubator-pekko/actor/src/main/resources/reference.conf > incubator-pekko/actor-testkit-typed/src/main/resources/reference.conf > > incubator-pekko/actor-testkit-typed/src/test/resources/application-test.conf > incubator-pekko/actor-testkit-typed/src/test/resources/application.conf > incubator-pekko/actor-testkit-typed/src/test/resources/logback-test.xml > incubator-pekko/actor-tests/src/test/bind/etc/bind.keys > incubator-pekko/actor-tests/src/test/bind/etc/db.0 > incubator-pekko/actor-tests/src/test/bind/etc/db.127 > incubator-pekko/actor-tests/src/test/bind/etc/db.255 > incubator-pekko/actor-tests/src/test/bind/etc/db.bar.example > incubator-pekko/actor-tests/src/test/bind/etc/db.empty > incubator-pekko/actor-tests/src/test/bind/etc/db.foo.test > incubator-pekko/actor-tests/src/test/bind/etc/db.local > incubator-pekko/actor-tests/src/test/bind/etc/db.root > incubator-pekko/actor-tests/src/test/bind/etc/named.conf > incubator-pekko/actor-tests/src/test/bind/etc/named.conf.default-zones > incubator-pekko/actor-tests/src/test/bind/etc/named.conf.local > incubator-pekko/actor-tests/src/test/bind/etc/named.conf.options > incubator-pekko/actor-tests/src/test/bind/etc/rndc.key > incubator-pekko/actor-tests/src/test/bind/etc/zones.rfc1918 > incubator-pekko/actor-tests/src/test/resources/reference.conf > > incubator-pekko/actor-typed/src/main/mima-filters/1.0.x.backwards.excludes/jfr.excludes > incubator-pekko/actor-typed/src/main/resources/reference.conf > incubator-pekko/actor-typed-tests/src/test/resources/logback-doc-dev.xml > incubator-pekko/actor-typed-tests/src/test/resources/logback-doc-prod.xml > incubator-pekko/actor-typed-tests/src/test/resources/logback-doc-test.xml > incubator-pekko/actor-typed-tests/src/test/resources/logback-test.xml > > incubator-pekko/actor-typed-tests/src/test/resources/mailbox-config-sample.conf > incubator-pekko/bench-jmh/src/main/resources/logback.xml > > incubator-pekko/bench-jmh/src/main/scala/org/apache/pekko/stream/NewLayoutBenchmark.template > incubator-pekko/cluster/jmx-client/pekko-cluster > incubator-pekko/cluster/src/main/resources/reference.conf > incubator-pekko/cluster-metrics/src/main/resources/reference.conf > incubator-pekko/cluster-metrics/src/test/resources/logback-test.xml > > incubator-pekko/cluster-sharding/src/main/mima-filters/1.0.x.backwards.excludes/jdk-11-specific-classes.excludes > incubator-pekko/cluster-sharding/src/main/resources/reference.conf > incubator-pekko/cluster-sharding/src/test/resources/adaptivity-trace.conf > > incubator-pekko/cluster-sharding/src/test/resources/arc-trace-database.conf > incubator-pekko/cluster-sharding/src/test/resources/arc-trace-search.conf > > incubator-pekko/cluster-sharding/src/test/resources/lirs-trace-glimpse.conf > incubator-pekko/cluster-sharding/src/test/resources/lirs-trace-multi.conf > > incubator-pekko/cluster-sharding/src/test/resources/lirs-trace-postgres.conf > incubator-pekko/cluster-sharding/src/test/resources/lirs2-trace-w106.conf > incubator-pekko/cluster-sharding/src/test/resources/reference.conf > incubator-pekko/cluster-sharding/src/test/resources/synthetic-loop.conf > > incubator-pekko/cluster-sharding/src/test/resources/synthetic-zipfian.conf > incubator-pekko/cluster-sharding/src/test/resources/text-moby-dick.conf > > incubator-pekko/cluster-sharding/src/test/resources/wikipedia-trace-2018.conf > incubator-pekko/cluster-sharding-typed/src/main/resources/reference.conf > > incubator-pekko/cluster-sharding-typed/src/multi-jvm/resources/logback-test.xml > > incubator-pekko/cluster-sharding-typed/src/test/resources/logback-test.xml > incubator-pekko/cluster-tools/src/main/resources/reference.conf > incubator-pekko/cluster-typed/src/main/resources/reference.conf > incubator-pekko/cluster-typed/src/multi-jvm/resources/logback-test.xml > incubator-pekko/cluster-typed/src/test/resources/logback-test.xml > incubator-pekko/coordination/src/main/resources/reference.conf > incubator-pekko/discovery/src/main/resources/reference.conf > incubator-pekko/distributed-data/src/main/resources/reference.conf > incubator-pekko/docs/src/main/paradox/.htaccess > incubator-pekko/docs/src/main/paradox/_template/projectSpecificFooter.st > incubator-pekko/docs/src/main/paradox/assets/js/warnOldDocs.js > incubator-pekko/docs/src/main/paradox/images/actor_lifecycle.svg > incubator-pekko/docs/src/main/paradox/images/association_lifecycle.svg > incubator-pekko/docs/src/main/paradox/images/circuit-breaker-states.dot > incubator-pekko/docs/src/main/paradox/images/composition.svg > incubator-pekko/docs/src/main/paradox/images/faulttolerancesample.graffle > incubator-pekko/docs/src/main/paradox/images/graph_stage_chain.svg > incubator-pekko/docs/src/main/paradox/images/graph_stage_conceptual.svg > > incubator-pekko/docs/src/main/paradox/images/graph_stage_detached_tracks_1.svg > > incubator-pekko/docs/src/main/paradox/images/graph_stage_detached_tracks_2.svg > incubator-pekko/docs/src/main/paradox/images/graph_stage_duplicate.svg > incubator-pekko/docs/src/main/paradox/images/graph_stage_filter.svg > incubator-pekko/docs/src/main/paradox/images/graph_stage_map.svg > incubator-pekko/docs/src/main/paradox/images/graph_stage_tracks_1.svg > > incubator-pekko/docs/src/main/paradox/images/persistence-detach-models.graffle > > incubator-pekko/docs/src/main/paradox/images/persistence-detach-models.svg > > incubator-pekko/docs/src/main/paradox/images/persistence-drop-event-serializer.graffle > > incubator-pekko/docs/src/main/paradox/images/persistence-drop-event-serializer.svg > > incubator-pekko/docs/src/main/paradox/images/persistence-drop-event.graffle > incubator-pekko/docs/src/main/paradox/images/persistence-drop-event.svg > > incubator-pekko/docs/src/main/paradox/images/persistence-event-adapter-1-n.graffle > > incubator-pekko/docs/src/main/paradox/images/persistence-event-adapter-1-n.svg > > incubator-pekko/docs/src/main/paradox/images/persistence-manual-rename.graffle > > incubator-pekko/docs/src/main/paradox/images/persistence-serializer-rename.graffle > > incubator-pekko/docs/src/main/paradox/images/persistence-serializer-rename.svg > > incubator-pekko/docs/src/main/paradox/images/persistent-message-envelope.graffle > > incubator-pekko/docs/src/main/paradox/images/persistent-message-envelope.svg > incubator-pekko/docs/src/main/paradox/images/port_transitions.svg > incubator-pekko/docs/src/main/paradox/images/tcp-message-protocol.graffle > > incubator-pekko/docs/src/main/paradox/images/tcp-message-protocol_bind-connect-maxed-out.svg > > incubator-pekko/docs/src/main/paradox/images/tcp-message-protocol_binding.svg > > incubator-pekko/docs/src/main/paradox/images/tcp-message-protocol_closing.svg > > incubator-pekko/docs/src/main/paradox/images/tcp-message-protocol_establishing-incoming.svg > > incubator-pekko/docs/src/main/paradox/images/tcp-message-protocol_establishing-outgoing.svg > > incubator-pekko/docs/src/main/paradox/images/tcp-message-protocol_noticing-close.svg > > incubator-pekko/docs/src/main/paradox/images/tcp-message-protocol_receiving.svg > > incubator-pekko/docs/src/main/paradox/images/tcp-message-protocol_unbinding.svg > > incubator-pekko/docs/src/main/paradox/images/tcp-message-protocol_writing.svg > incubator-pekko/docs/src/main/paradox/images/tcp-stream-bind.svg > incubator-pekko/docs/src/main/paradox/images/tcp-stream-run.svg > > incubator-pekko/docs/src/main/paradox/typed/guide/diagrams/actor_graph.svg > > incubator-pekko/docs/src/main/paradox/typed/guide/diagrams/arch_boxes_diagram.svg > > incubator-pekko/docs/src/main/paradox/typed/guide/diagrams/arch_tree_diagram.svg > > incubator-pekko/docs/src/main/paradox/typed/guide/diagrams/device_manager_tree.svg > > incubator-pekko/docs/src/main/paradox/typed/guide/diagrams/exception_prop.svg > > incubator-pekko/docs/src/main/paradox/typed/guide/diagrams/object_graph.svg > > incubator-pekko/docs/src/main/paradox/typed/guide/diagrams/object_graph_snakes.svg > incubator-pekko/docs/src/main/paradox/typed/guide/diagrams/seq_chart.svg > > incubator-pekko/docs/src/main/paradox/typed/guide/diagrams/seq_chart_multi_thread.svg > > incubator-pekko/docs/src/main/paradox/typed/guide/diagrams/seq_chart_thread.svg > > incubator-pekko/docs/src/main/paradox/typed/guide/diagrams/serialized_timeline_invariants.svg > incubator-pekko/docs/src/test/resources/application.conf > incubator-pekko/docs/src/test/resources/logback-test.xml > incubator-pekko/kubernetes/.gitignore > incubator-pekko/kubernetes/setup.sh > incubator-pekko/kubernetes/test-node-base.yaml > incubator-pekko/legal/PekkoNotice.txt > incubator-pekko/legal/pekko-remote-jar-notice.txt > incubator-pekko/multi-node-testkit/src/main/resources/reference.conf > incubator-pekko/osgi/src/test/resources/logback-test.xml > incubator-pekko/persistence/src/main/resources/reference.conf > incubator-pekko/persistence-query/src/main/resources/reference.conf > incubator-pekko/persistence-testkit/src/main/resources/reference.conf > incubator-pekko/persistence-testkit/src/test/resources/application.conf > incubator-pekko/persistence-testkit/src/test/resources/logback-test.xml > incubator-pekko/persistence-typed/src/main/resources/reference.conf > incubator-pekko/persistence-typed/src/test/resources/logback-test.xml > > incubator-pekko/persistence-typed-tests/src/test/resources/logback-test.xml > > incubator-pekko/plugins/serialversion-remover-plugin/src/main/resources/plugin.properties > incubator-pekko/project/build.properties > incubator-pekko/project/project-info.conf > incubator-pekko/project/scripts/find-replace > incubator-pekko/project/scripts/validate-automatic-module-names > > incubator-pekko/remote/src/main/mima-filters/1.0.x.backwards.excludes/jdk11-specific-classes.backwards.excludes > > incubator-pekko/remote/src/main/mima-filters/1.0.x.backwards.excludes/pducodec.backwards.excludes > incubator-pekko/remote/src/main/resources/reference.conf > incubator-pekko/remote/src/test/resources/Makefile > incubator-pekko/remote/src/test/resources/aeron.properties > incubator-pekko/remote/src/test/resources/domain.crt > incubator-pekko/remote/src/test/resources/ssl/client.example.com.crt > incubator-pekko/remote/src/test/resources/ssl/exampleca.crt > incubator-pekko/remote/src/test/resources/ssl/ > gen-artery-nodes.example.com.sh > incubator-pekko/remote/src/test/resources/ssl/gen-functions.sh > incubator-pekko/remote/src/test/resources/ssl/genca.sh > incubator-pekko/remote/src/test/resources/ssl/gencerts.sh > incubator-pekko/remote/src/test/resources/ssl/island.example.com.crt > incubator-pekko/remote/src/test/resources/ssl/node.example.com.crt > incubator-pekko/remote/src/test/resources/ssl/one.example.com.crt > incubator-pekko/remote/src/test/resources/ssl/password > incubator-pekko/remote/src/test/resources/ssl/rsa-client.example.com.crt > incubator-pekko/remote/src/test/resources/ssl/two.example.com.crt > > incubator-pekko/remote/src/test/resources/ssl/artery-nodes/artery-node001.example.com.crt > > incubator-pekko/remote/src/test/resources/ssl/artery-nodes/artery-node002.example.com.crt > > incubator-pekko/remote/src/test/resources/ssl/artery-nodes/artery-node003.example.com.crt > > incubator-pekko/remote-tests/src/multi-jvm/scala/org/apache/pekko/remote/artery/DirectMemorySpecMultiJvmNode1.opts > > incubator-pekko/remote-tests/src/multi-jvm/scala/org/apache/pekko/remote/artery/DirectMemorySpecMultiJvmNode2.opts > incubator-pekko/scripts/authors.scala > incubator-pekko/scripts/convert_tabs_to_spaces.sh > incubator-pekko/scripts/dos_to_unix.sh > incubator-pekko/scripts/find-javadoc-error.pl > incubator-pekko/scripts/find_fixed_tickets.sh > incubator-pekko/scripts/ip-mod.sh > incubator-pekko/scripts/line_count.sh > incubator-pekko/scripts/link-validator.conf > incubator-pekko/scripts/multi-node-log-replace.sh > incubator-pekko/scripts/release_stats.sh > incubator-pekko/scripts/remove_trailing_whitespace.sh > incubator-pekko/scripts/show-serializer.sh > incubator-pekko/serialization-jackson/src/main/resources/reference.conf > incubator-pekko/serialization-jackson/src/test/resources/reference.conf > incubator-pekko/slf4j/src/test/resources/logback-test.xml > > incubator-pekko/stream/src/main/mima-filters/1.0.x.backwards.excludes/28324-jdk9-specific-classes.backwards.excludes > incubator-pekko/stream/src/main/resources/reference.conf > incubator-pekko/stream-testkit/src/main/resources/reference.conf > incubator-pekko/stream-testkit/src/test/resources/reference.conf > incubator-pekko/stream-tests/src/test/resources/Makefile > incubator-pekko/stream-tests/src/test/resources/reference.conf > incubator-pekko/stream-typed/src/test/resources/logback-test.xml > incubator-pekko/testkit/src/main/resources/reference.conf > incubator-pekko/testkit/src/test/resources/reference.conf > {noformat} > > On Wed, Jul 19, 2023 at 3:22 PM Claude Warren, Jr <[email protected]> > wrote: > >> PJ, >> >> I just did a test with the latest RAT and it does understand the headers. >> >> It does not understand: >> >> # SPDX-License-Identifier: Apache-2.0 >> >> But the ones you reference, which I assume are in the java and scala >> files it recognizes just fine. >> >> Claude >> >> On Wed, Jul 19, 2023 at 11:13 AM PJ Fanning <[email protected]> wrote: >> >>> the Rat tool does not understand the header in >>> https://issues.apache.org/jira/browse/LEGAL-626 >>> >>> On Wed, 19 Jul 2023 at 10:08, Claude Warren, Jr >>> <[email protected]> wrote: >>> > >>> > It may make sense to run the Rat tool within the RC build so that we >>> can >>> > get a handle on all the issues that Justin is finding before Justin >>> finds >>> > them. Then we can properly address them before the RC is proposed. >>> > >>> > On Wed, Jul 19, 2023 at 10:45 AM kerr <[email protected]> wrote: >>> > >>> > > I think https://github.com/apache/incubator-pekko-http/pull/115 can >>> be >>> > > included in the first RC too. >>> > > >>> > > 何品 >>> > > >>> > > >>> > > Johannes Rudolph <[email protected]> 于2023年7月19日周三 14:53写道： >>> > > >>> > > > Thanks for the release, PJ, and thanks for the review, Justin, I'll >>> > > > create tickets to address the problems. >>> > > > >>> > > > On Wed, Jul 19, 2023 at 5:31 AM Justin Mclean < >>> [email protected]> >>> > > > wrote: >>> > > > > >>> > > > > Hi, >>> > > > > >>> > > > > -1 (binding) from me. Given the large number of issues I may have >>> > > missed >>> > > > something. >>> > > > > >>> > > > > I checked: >>> > > > > - incubating in the name >>> > > > > - signatures and hashes are fine >>> > > > > - DISCLAIMER >>> > > > > - LICENSE is possibly missing 3rd party code licenses due to the >>> number >>> > > > of files with missing headers? Also these 3rd party files files >>> > > > [26][27][28][29][30][31][32][33][34] >>> > > > > - NOTICE is fine >>> > > > > - These files are missing headers and are of an unknown license >>> > > > [1][9][10][11][12][13][14][16][17][18][19][20][21][22][23][24] >>> > > > > - These files seem to have incorrect headers >>> [2][3][4][5][6][7][8][15] >>> > > > > - This file (mentioned in license) also has an incorrect header >>> [35] >>> > > > > - No unexpected binary files >>> > > > > >>> > > > > I don't recall the software grant mentioned in the notice file >>> to have >>> > > > undergone IP clearance. Can you point me to where this was done? >>> > > > > >>> > > > > You might want to consider making this file part of the build >>> process >>> > > or >>> > > > downloading it rather than including it in the source release. [25] >>> > > > > >>> > > > > Kind Regards, >>> > > > > Justin >>> > > > > >>> > > > > 1. ./docs/src/main/paradox/assets/js/scrollToFragment.js >>> > > > > 2. >>> > > > >>> > > >>> ./http/src/main/boilerplate/org/apache/pekko/http/javadsl/server/JavaPathMatchers.scala.template >>> > > > > 3. >>> > > > >>> > > >>> ./http/src/main/boilerplate/org/apache/pekko/http/scaladsl/server/directives/FormFieldDirectivesInstances.scala.template >>> > > > > 4. >>> > > > >>> > > >>> ./http/src/main/boilerplate/org/apache/pekko/http/scaladsl/server/directives/ParameterDirectivesInstances.scala.template >>> > > > > 5. >>> > > > >>> > > >>> ./http/src/main/boilerplate/org/apache/pekko/http/scaladsl/server/util/ApplyConverterInstances.scala.template >>> > > > > 6. >>> > > > >>> > > >>> ./http/src/main/boilerplate/org/apache/pekko/http/scaladsl/server/util/ConstructFromTupleInstances.scala.template >>> > > > > 7. >>> > > > >>> > > >>> ./http/src/main/boilerplate/org/apache/pekko/http/scaladsl/server/util/TupleAppendOneInstances.scala.template >>> > > > > 8. >>> > > > >>> > > >>> ./http/src/main/boilerplate/org/apache/pekko/http/scaladsl/server/util/TupleFoldInstances.scala.template >>> > > > > 9. >>> > > ./http-core/src/test/scripts/autobahn-jenkins/step-1-client-tests.sh >>> > > > > 10. >>> > > > >>> ./http-core/src/test/scripts/autobahn-jenkins/step-2-run-sbt-client.sh >>> > > > > 11. >>> > > > >>> > > >>> ./http-core/src/test/scripts/autobahn-jenkins/step-3-download-client-test-results.sh >>> > > > > 12. >>> > > > >>> > > >>> ./http-core/src/test/scripts/autobahn-jenkins/step-4-stop-client-tests-server.sh >>> > > > > 13. >>> > > > >>> ./http-core/src/test/scripts/autobahn-jenkins/step-5-server-tests-all.sh >>> > > > > 14. >>> > > > >>> ./http-core/src/test/scripts/autobahn-jenkins/step-6-collect-results.sh >>> > > > > 15. >>> > > > >>> > > >>> ./http-scalafix/scalafix-tests/src/test/scala/org/apache/pekko/http/fix/RuleSuite.scala >>> > > > > 16. ./scripts/authors.pl >>> > > > > 17. ./scripts/authors.scala >>> > > > > 18. ./scripts/commits-for-release-notes.sh >>> > > > > 19. ./scripts/convert_tabs_to_spaces.sh >>> > > > > 20. ./scripts/dos_to_unix.sh >>> > > > > 21. ./scripts/find-javadoc-error.pl >>> > > > > 22. ./scripts/release_stats.sh >>> > > > > 23. ./scripts/remove_trailing_whitespace.sh >>> > > > > 24. ./scripts/build/github-tagging.sh >>> > > > > 25. ./http-tests/src/test/extra-libs.zip >>> > > > > 26. >>> > > > >>> > > >>> ./http-core/src/main/scala/org/apache/pekko/http/impl/engine/ws/Utf8Decoder.scala >>> > > > > 27. >>> > > > >>> > > >>> ./http-core/src/main/scala/org/apache/pekko/http/impl/model/parser/StringBuilding.scala >>> > > > > 28. >>> > > > >>> > > >>> ./http-core/src/main/scala/org/apache/pekko/http/impl/engine/http2/util/AsciiTreeLayout.scala >>> > > > > 29. >>> > > > >>> > > >>> ./http-tests/src/test/java/org/apache/pekko/http/javadsl/marshalling/sse/EventStreamMarshallingTest.java >>> > > > > 30. >>> > > > >>> > > >>> ./http-tests/src/test/java/org/apache/pekko/http/javadsl/unmarshalling/sse/EventStreamUnmarshallingTest.java >>> > > > > 31. >>> > > > >>> > > >>> ./http-core/src/test/java/org/apache/pekko/http/javadsl/model/sse/ServerSentEventTest.java >>> > > > > 32. >>> > > > >>> > > >>> ./http-core/src/main/java/org/apache/pekko/http/javadsl/model/sse/ServerSentEvent.java >>> > > > > 33. >>> > > > >>> > > >>> ./http-core/src/main/java/org/apache/pekko/http/javadsl/model/headers/LastEventId.java >>> > > > > 34. >>> > > > >>> > > >>> ./http-core/src/main/scala-2.13-/org/apache/pekko/http/ccompat/CompatImpl.scala >>> > > > > 35. >>> > > > >>> > > >>> /http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/DateTime.scala >>> > > > > >>> > > > > >>> > > > > >>> > > > > >>> > > > > >>> --------------------------------------------------------------------- >>> > > > > To unsubscribe, e-mail: [email protected] >>> > > > > For additional commands, e-mail: [email protected] >>> > > > > >>> > > > >>> > > > >>> --------------------------------------------------------------------- >>> > > > To unsubscribe, e-mail: [email protected] >>> > > > For additional commands, e-mail: [email protected] >>> > > > >>> > > > >>> > > >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>>
