On Thu, 18 Oct 2001, Stas Bekman wrote: > OK, here is the generalization of your proof-of-concept. Note that I've > created a new test pair instead of patching the existing one so it'll be > easier to see what happens, since there is not much left from the existing > one. Once everything is dandy I'll override the existing modperl/interp > test.
looks good. > - It'd be nice to may be add a :common tag for Apache::TestRequest > exports, since now I've added @EXPORT_OK and if I want something from > @EXPORT_OK, I have to explicitly pull the tags from @EXPORT. i don't see any reason for @EXPORT_OK, Apache::TestRequest stuff should either be exported by default or called with the fully qualified name. GET,POST,etc. are most often used, Apache::TestRequest::same_pi_foo doesn't seem much of a burden. i also wonder if the name should be more descriptive, Apache::TestRequest::same_interp or something, 'pi' makes me think of math. and the INTERP constant should only be defined once (and maybe called INTERP_KEY or something else), and used elsewhere with fully qualified name: Apache::TestRequest::INTERP_KEY but those are just nits, everything else looks good. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
