>>- It'd be nice to may be add a :common tag for Apache::TestRequest >>exports, since now I've added @EXPORT_OK and if I want something from >>@EXPORT_OK, I have to explicitly pull the tags from @EXPORT. >> > > i don't see any reason for @EXPORT_OK, Apache::TestRequest stuff should > either be exported by default or called with the fully qualified name. > GET,POST,etc. are most often used, Apache::TestRequest::same_pi_foo > doesn't seem much of a burden. > i also wonder if the name should be more descriptive, > Apache::TestRequest::same_interp or something, 'pi' makes me think of > math. and the INTERP constant should only be defined once (and maybe > called INTERP_KEY or something else), and used elsewhere with fully > qualified name: Apache::TestRequest::INTERP_KEY > > but those are just nits, everything else looks good.
all comments applied and committed. _____________________________________________________________________ Stas Bekman JAm_pH -- Just Another mod_perl Hacker http://stason.org/ mod_perl Guide http://perl.apache.org/guide mailto:[EMAIL PROTECTED] http://ticketmaster.com http://apacheweek.com http://singlesheaven.com http://perl.apache.org http://perlmonth.com/ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
