two issues with this patch: - as i mentioned, the code for sending the scoreboard image doesn't belong tied to modperl, as it can be used in a server without modperl. there should be a mod_scoreboard_send.c that can be compiled with apxs without any perl stuff. it could then export an optional function for the perl wrapper to call the send function.
- looking at the patch, seems that WrapXS is more trouble than a help here. that is, normally WrapXS takes care of many things for you, but in this case it looks like too much extra effort is happening. there is so much mpxs_Apache__Scoreboard_* and _pm and DEFINE_* and MPXS_*'s that make the code harder to read and more difficult to maintain than if everything was done in a standard xs module without WrapXS. i'm thinking at the very least, the code should be moved to a self-contained Apache-Scoreboard subdirectory, using standard xs. and given that mod_scoreboard_send.c should be usable without modperl, perhaps this stuff should not be part of the modperl core, but its own package like 1.x. thoughts? --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
