Doug MacEachern wrote: > two issues with this patch: > > - as i mentioned, the code for sending the scoreboard image doesn't belong > tied to modperl, as it can be used in a server without modperl. there > should be a mod_scoreboard_send.c that can be compiled with apxs without > any perl stuff. it could then export an optional function for the perl > wrapper to call the send function.
Of course, this is just temporary until the new home will be found. I was thinking about putting this functionality into mod_status, instead creating a new module. After all it already has a mode in which it responds with something similar to an image. > - looking at the patch, seems that WrapXS is more trouble than a help > here. that is, normally WrapXS takes care of many things for you, but in > this case it looks like too much extra effort is happening. there is so > much mpxs_Apache__Scoreboard_* and _pm and DEFINE_* and MPXS_*'s that > make the code harder to read and more difficult to maintain than if > everything was done in a standard xs module without WrapXS. Well, the interface is not much different from Apache::Scoreboard for 1.x, so no surprises here. > i'm thinking at the very least, the code should be moved to a > self-contained Apache-Scoreboard subdirectory, using standard xs. > and given that mod_scoreboard_send.c should be usable without modperl, > perhaps this stuff should not be part of the modperl core, but its own > package like 1.x. thoughts? Sure, this can be done. Though I'm really not interested in expanding the ownership of the privately owned CPAN modules, but rather try to move all my works somewhere where other people can fix problems if I'm not around. So if the modules that I've developed or ported can be hosted at apache.org cvs or elsewhere that's cool with me. I'll still be the active developer/maintainer of these. BTW, Doug, you can do the same for a bunch of the 1.x modules you own at CPAN. I believe that putting the sources under public control will make a better progress on these sources. Apache::Scoreboard comes to mind. Just a thought. So how about creating a new repository modperl-2.0-modules or modperl-modules-2.0 and put Apache-Scoreboard there. Probably move Apache-Test and ModPerl-Registry there too. That will allow us to keep the core small, and still have a bunch of modules installable from one directory. So we may end up distributing modperl-2.x and modperl-modules-2.x and a combined version. One concern is whether these modules can use WrapXS, it is going to be a problem to split them away till Gerald will come back with a standalone version. __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
