Geoffrey Young wrote:
A s/VOID/MP_VOID/ gets around this, but

perhaps there's a more intuitive name?


bah - I _knew_ that would be a problem for somebody...



And it's usually Win32 :)



:)



I'd suggest renaming them all to MP_ or MP_HOOK_.



How about the following?


looks good. however, after thinking about it, I'm more inclined to use MP_HOOK instead - MP_VOID feels like it could have multiple meanings depending on context, whereas MP_HOOK_VOID feels a bit more descriptive.

maybe let stas or another committer weigh in first. other than that, looks good to me. sorry I didn't follow my instincts the first time :)

+1 on MP_HOOK_*


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to