hi
I've implemented apr_table_compress, which was recently added to the APR table API.
the only thing I'm unsure about is what our position is on APR changes - can we rely on the autogeneration code for this (and perhaps other recent additions), breaking back compat, or do we need some kind of wrapper to protect users with older httpd/apr versions?
since we don't have a wrapper, this is not a problem for the code generation, as it'll be just ignored.
If we do have a wrapper then we need #if/#else/#end logic, which is not the case with this function.
So the only thing you need is to fix the test to run the sub-tests only if apache version is the minimal one that has this feature.
--Geoff
------------------------------------------------------------------------
Index: docs/api/APR/Table.pod
===================================================================
RCS file: /home/cvspublic/modperl-docs/src/docs/2.0/api/APR/Table.pod,v
retrieving revision 1.2
diff -u -r1.2 Table.pod
--- docs/api/APR/Table.pod 5 Jun 2003 06:37:39 -0000 1.2
+++ docs/api/APR/Table.pod 18 Aug 2003 19:40:29 -0000
@@ -250,6 +250,22 @@
return: A new table containing all of the data from the two passed in
The pod is broken a bit, instead of empty lines you have lines full of spaces, which will break the pod parser. Time to fix/replace your editor?
+=item * compress()
s/compress/overlap/
+ overlap($table, $flags);
+ +Compress the data in C<$table>.
probably add a comment of what does it mean, while you are at it. I'm not quite sure what does it do from reading this.
+param C<$table>: The table to add the data to.
+ +param C<$flags>: How to compress C<$table>.
+ +When C<$flags> == C<APR_OVERLAP_TABLES_SET>, each key will be +set to the last value seen for that key.
should this be:
APR::OVERLAP_TABLES_SET?
and below? plus
use APR::Const ... use APR::Const -compile => qw(APR::OVERLAP_TABLES_SET OVERLAP_TABLES_MERGE);
+When C<$flags> == C<APR_OVERLAP_TABLES_MERGE>, multiple values
+for the same key are flattened into a comma-separated list.
+ =back
=head2 TIE Interface
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
