yeah, that's a consideration. I've cleaned up the code to remove all back-compat stuff for versions prior to 2.0.46. I'll let it run through my nightly builds and see how it went tomorrow.
everything looks ok, with the exception of t/filter/TestFilter/in_str_consume.pm, which hangs even though the comments say it should only hang for 2.0.40 and older.
I can't reproduce that. please post a complete bug report so I can try to match your setup.
so, attached is a patch that tested fine for me on 2.0.46 and 2.0.47 under perl-5.8.0, and I'm running it against 2.0 cvs, 2.1 cvs, and perl variants now.
please give it a whirl and let me know how it goes or if you think I missed something.
Looks great, geoff!
Two small comments:
Index: src/modules/perl/mod_perl.c
===================================================================
RCS file: /home/cvspublic/modperl-2.0/src/modules/perl/mod_perl.c,v
retrieving revision 1.179
diff -u -r1.179 mod_perl.c
--- src/modules/perl/mod_perl.c 20 Aug 2003 23:20:14 -0000 1.179
+++ src/modules/perl/mod_perl.c 22 Aug 2003 14:59:28 -0000
@@ -689,12 +689,7 @@
apr_pool_cleanup_null);
}
-/* api change in 2.0.40-ish */
-#if (MODULE_MAGIC_NUMBER_MAJOR >= 20020628)
-# define MP_FILTER_HANDLER(f) f, NULL
-#else
-# define MP_FILTER_HANDLER(f) f
-#endif
+#define MP_FILTER_HANDLER(f) f, NULL
there is no need in this define then, should go and replace it with f, NULL where it's used. (can do that in a separate pass).
Index: t/filter/TestFilter/in_str_consume.pm
===================================================================
RCS file: /home/cvspublic/modperl-2.0/t/filter/TestFilter/in_str_consume.pm,v
retrieving revision 1.6
diff -u -r1.6 in_str_consume.pm
--- t/filter/TestFilter/in_str_consume.pm 7 Aug 2003 19:12:29 -0000 1.6
+++ t/filter/TestFilter/in_str_consume.pm 22 Aug 2003 14:59:29 -0000
@@ -53,10 +53,11 @@
}
# this is not needed in newer Apache versions, however older
- # versions (2.0.40) will repeatedly call this filter, waiting
+ # versions (2.0.46) will repeatedly call this filter, waiting
# for EOS which will never come from this filter so, after
# several invocations mark the seen_eos flag, to break the
# vicious cirle
+ # BACK_COMPAT_MARKER: make back compat issues easy to find
if ($count > 10) {
$filter->seen_eos(1);
}
but the problem doesn't happen with 2.0.46, only in 2.0.40. why s/2.0.40/2.0.46/?
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
