On Wed, 30 Jun 2004, Stas Bekman wrote:
> Randy Kobes wrote:
> > On Win32, the first subtest of api/sendfile.t fails
> > due to different line endings. This diff:
> > ====================================================
> > Index: t/api/sendfile.t
> > ===================================================================
> > RCS file: /home/cvs/modperl-2.0/t/api/sendfile.t,v
> > retrieving revision 1.7
> > diff -u -r1.7 sendfile.t
> > --- t/api/sendfile.t 29 Jun 2004 22:56:16 -0000 1.7
> > +++ t/api/sendfile.t 1 Jul 2004 04:43:55 -0000
> > @@ -4,6 +4,7 @@
> > use Apache::Test;
> > use Apache::TestUtil;
> > use Apache::TestRequest;
> > +use Apache::TestConfig ();
> >
> > use File::Spec::Functions qw(catfile);
> >
> > @@ -24,6 +25,7 @@
> > close $fh;
> >
> > my $received = GET_BODY($url);
> > + $received =~ s{\r}{}g if Apache::TestConfig::WIN32;
> >
> > t_debug($received);
> > ok $received && $received eq $expected;
> >
> > ==================================================================
> > fixes it.
>
> How about a fix without win32 branching -- just drop "\n"
> on both sides? Or is it the one coming from a file that is
> sendfile'd?
It's that coming from the file being sendfile'd. And I guess
we shouldn't alter with what sendfile produces?
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
