Randy Kobes wrote:
On Wed, 30 Jun 2004, Stas Bekman wrote:


Randy Kobes wrote:

On Win32, the first subtest of api/sendfile.t fails
due to different line endings. This diff:
[...]
    my $received = GET_BODY($url);
+    $received =~ s{\r}{}g if Apache::TestConfig::WIN32;
[...]
==================================================================
fixes it.

How about a fix without win32 branching -- just drop "\n" on both sides? Or is it the one coming from a file that is sendfile'd?


It's that coming from the file being sendfile'd. And I guess
we shouldn't alter with what sendfile produces?

Hmm, is that correct at all? why would it stuff \r into a file that didn't have it? Or does it do that only for text files (assuming it somehow figures out it's not a binary file). What if you send an image file, does it stuff \r there too if it finds \n?



-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to