> +        # the APR_EGENERAL error string changed for APR 1.0
> +        my $egeneral = "Error string not specified yet";
> +        $egeneral = "Internal error"
> +            if need_min_apache_version('2.1.0');

this should be have_min_apache_version() instead.  basically, use the need*
variants in calls to plan() and have* variants everywhere else, as need*
adds to the global test skip message, which can leak across tests.

other than that, looks great :)

I'm looking into the content_length failure now.  what I think is happening
there is that we coded it as httpd behaved at the moment, but that something
has recently changed over there and I'm just now catching up on my email.

as an aside, I think we kind of informally agreed that the tests in t/apache
were for testing internal apache things in an attempt to let us know when
some basic httpd functionality changed that we should be knowing about.  so,
in this case, that the behavior of a handler with a zero content length has
changed wrt the C-L header isn't as important to mod_perl as it is to us
understanding things when users report problems (which was the reason we
wrote this particular test IIRC).

anyway, I'm building against current cvs now after a few days of travelling,
so I hope to have a solution for that test soon.

--Geoff

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to