[
https://issues.apache.org/jira/browse/PHOENIX-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059702#comment-14059702
]
ASF GitHub Bot commented on PHOENIX-933:
----------------------------------------
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14852114
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseTenantSpecificViewIndexIT.java
---
@@ -117,26 +139,38 @@ private Connection createTenantConnection(String
tenantId) throws SQLException {
private void verifyViewData(Connection conn, String valuePrefix)
throws SQLException {
String query = "SELECT k1, k2, v2 FROM v WHERE v2='" + valuePrefix
+ "v2-1'";
ResultSet rs = conn.createStatement().executeQuery(query);
- assertTrue(rs.next());
- assertEquals(1, rs.getInt(1));
- assertEquals(1, rs.getInt(2));
- assertEquals(valuePrefix + "v2-1", rs.getString(3));
- assertTrue(rs.next());
- assertEquals(1, rs.getInt(1));
- assertEquals(3, rs.getInt(2));
- assertEquals(valuePrefix + "v2-1", rs.getString(3));
- assertTrue(rs.next());
- assertEquals(1, rs.getInt(1));
- assertEquals(5, rs.getInt(2));
- assertEquals(valuePrefix + "v2-1", rs.getString(3));
- assertTrue(rs.next());
- assertEquals(1, rs.getInt(1));
- assertEquals(7, rs.getInt(2));
- assertEquals(valuePrefix + "v2-1", rs.getString(3));
- assertTrue(rs.next());
- assertEquals(1, rs.getInt(1));
- assertEquals(9, rs.getInt(2));
- assertEquals(valuePrefix + "v2-1", rs.getString(3));
+ List<List<Object>> expectedResultsA = Lists.newArrayList(
+ Arrays.<Object>asList(1,1, valuePrefix + "v2-1"),
+ Arrays.<Object>asList(1,3, valuePrefix + "v2-1"),
+ Arrays.<Object>asList(1,5, valuePrefix + "v2-1"),
+ Arrays.<Object>asList(1,7, valuePrefix + "v2-1"),
+ Arrays.<Object>asList(1,9, valuePrefix + "v2-1"));
+ assertValuesEqualsResultSet(rs,expectedResultsA);
assertFalse(rs.next());
}
+
--- End diff --
This code looks familiar. If it matches original (I think from QueryIT),
can you move it into the base test class instead of copy/paste?
> Local index support to Phoenix
> ------------------------------
>
> Key: PHOENIX-933
> URL: https://issues.apache.org/jira/browse/PHOENIX-933
> Project: Phoenix
> Issue Type: New Feature
> Reporter: rajeshbabu
>
> Hindex(https://github.com/Huawei-Hadoop/hindex) provides local indexing
> support to HBase. It stores region level index in a separate table, and
> co-locates the user and index table regions with a custom load balancer.
> See http://goo.gl/phkhwC and http://goo.gl/EswlxC for more information.
> This JIRA addresses the local indexing solution integration to phoenix.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
