[
https://issues.apache.org/jira/browse/PHOENIX-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059899#comment-14059899
]
ASF GitHub Bot commented on PHOENIX-933:
----------------------------------------
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14855032
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/SkipRangeParallelIteratorRegionSplitter.java
---
@@ -54,7 +55,8 @@ protected
SkipRangeParallelIteratorRegionSplitter(StatementContext context, Tabl
public List<HRegionLocation> filterRegions(List<HRegionLocation>
allTableRegions, final ScanRanges ranges) {
Iterable<HRegionLocation> regions;
- if (ranges == ScanRanges.EVERYTHING) {
+ if (ranges == ScanRanges.EVERYTHING
--- End diff --
This shouldn't be necessary and will cause the skip scan not to be used
(which will be horrible for point queries). It should work fine to do the skip
scan for each region (much better than doing a full region scan for every
region).
Can you remove it and add a test that does a point lookup with multiple
values (for example, a IN clause with multiple values for an indexed column)?
> Local index support to Phoenix
> ------------------------------
>
> Key: PHOENIX-933
> URL: https://issues.apache.org/jira/browse/PHOENIX-933
> Project: Phoenix
> Issue Type: New Feature
> Reporter: rajeshbabu
>
> Hindex(https://github.com/Huawei-Hadoop/hindex) provides local indexing
> support to HBase. It stores region level index in a separate table, and
> co-locates the user and index table regions with a custom load balancer.
> See http://goo.gl/phkhwC and http://goo.gl/EswlxC for more information.
> This JIRA addresses the local indexing solution integration to phoenix.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
