[ 
https://issues.apache.org/jira/browse/PHOENIX-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060205#comment-14060205
 ] 

ASF GitHub Bot commented on PHOENIX-933:
----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/3#discussion_r14859843
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java ---
    @@ -169,7 +170,7 @@ private boolean 
hasImmutableIndexWithKeyValueColumns(TableRef tableRef) {
             }
             for (PTable index : tableRef.getTable().getIndexes()) {
                 for (PColumn column : index.getPKColumns()) {
    -                if (!IndexUtil.isDataPKColumn(column)) {
    +                if (!IndexUtil.isDataPKColumn(column) && 
(index.getIndexType() != IndexType.LOCAL || 
!column.getName().toString().equals(MetaDataUtil.VIEW_INDEX_ID_COLUMN_NAME))) {
    --- End diff --
    
    Thinking about this more, it should probably just be disallowed to create a 
local index on a table with immutable rows. I'm not sure if there's a need and 
I suspect we haven't tested this combination. We can always add it 
down-the-road.


> Local index support to Phoenix
> ------------------------------
>
>                 Key: PHOENIX-933
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-933
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: rajeshbabu
>
> Hindex(https://github.com/Huawei-Hadoop/hindex) provides local indexing 
> support to HBase. It stores region level index in a separate table, and 
> co-locates the user and index table regions with a custom load balancer.
> See http://goo.gl/phkhwC and http://goo.gl/EswlxC for more information. 
> This JIRA addresses the local indexing solution integration to phoenix.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to