Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/3#discussion_r14873050
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/iterate/ParallelIterators.java ---
    @@ -238,7 +240,12 @@ private void 
doColumnProjectionOptimization(StatementContext context, Scan scan,
                             minMaxRange = 
SaltingUtil.addSaltByte(split.getLowerRange(), minMaxRange);
                             split = split.intersect(minMaxRange);
                         }
    -                }
    +                } else if (localIndex) {
    --- End diff --
    
    In a follow up commit, we should look to commonize the above salting logic 
with this logic for local indexes. It's doing the same thing, it's just adding 
one byte for the salt byte while the local indexing is adding the region start 
key.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to