Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/3#discussion_r14860610
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
 ---
    @@ -140,7 +142,14 @@ public boolean apply(HRegionLocation location) {
             // distributed across regions, using this scheme compensates for 
regions that
             // have more rows than others, by applying tighter splits and 
therefore spawning
             // off more scans over the overloaded regions.
    -        int splitsPerRegion = regions.size() >= targetConcurrency ? 1 : 
(regions.size() > targetConcurrency / 2 ? maxConcurrency : targetConcurrency) / 
regions.size();
    +        PTable table = tableRef.getTable();
    --- End diff --
    
    Please add TODO to add getSplitsPerRegion method to 
ParallelIteratorRegionSplitter so we can move this special case to your new 
implementation for local indexes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to