[ 
https://issues.apache.org/jira/browse/PHOENIX-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099482#comment-14099482
 ] 

James Taylor commented on PHOENIX-1166:
---------------------------------------

+1. LGTM, [~jeffreyz]. Thanks so much for the patch. Would you mind adding a 
TODO to revisit this special case once the backdoor connection is fixed?

[~jesse_yates] - I verified that the backdoor connection is working in 3.0 
under 0.94, but not for 4.0 under 0.98.4. I filed HBASE-11766 for this. Maybe 
it broken with the RPC rework in 0.98.4? To verify, I put a breakpoint in 
CoprocessorHConnection and verified that this function is never called:

  public 
org.apache.hadoop.hbase.protobuf.generated.ClientProtos.ClientService.BlockingInterface
      getClient(ServerName serverName) throws IOException {

Did the same in 0.94 in CoprocessorHConnection, and verified that this is 
called and correctly detects if remote or not:

  @Override
  HRegionInterface getHRegionConnection(final String hostname, final int port,



> Avoid HTable creation in coprocessors to write into local index table
> ---------------------------------------------------------------------
>
>                 Key: PHOENIX-1166
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1166
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: rajeshbabu
>            Assignee: rajeshbabu
>             Fix For: 5.0.0, 4.1
>
>         Attachments: PHOENIX-1166-jeff.patch, PHOENIX-1166.patch
>
>
> Since data table regions and local index regions colocated, we can get index 
> region directly from RS online regions and write to it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to