Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/30#discussion_r21877974
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/MinMaxAggregateFunctionIT.java
 ---
    @@ -0,0 +1,75 @@
    +package org.apache.phoenix.end2end;
    +
    +import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES;
    +import static org.junit.Assert.*;
    +
    +import java.sql.Connection;
    +import java.sql.DriverManager;
    +import java.sql.ResultSet;
    +import java.sql.SQLException;
    +import java.util.Properties;
    +
    +import org.apache.phoenix.util.PropertiesUtil;
    +import org.junit.Test;
    +
    +public class MinMaxAggregateFunctionIT extends BaseHBaseManagedTimeIT {
    +   
    +   @Test
    +   public void minMax() throws SQLException {
    --- End diff --
    
    By convention, we use test in the test name. How about something like 
testMinMaxForFixedLength()?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to