Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/30#discussion_r21878001
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/MaxAggregateFunction.java
---
@@ -58,6 +58,10 @@ public Aggregator newServerAggregator(Configuration
conf) {
public PDataType getDataType() {
return type;
}
+ @Override
+ public Integer getMaxLength() {
+ return getAggregatorExpression().getMaxLength();
--- End diff --
Minor nit, but maybe have a final local variable for
getAggregatorExpression() since we call it a number of times.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
