Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/34#discussion_r22997129
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ---
    @@ -883,6 +903,14 @@ public void readFields(DataInput input) throws 
IOException {
             dataEmptyKeyValueCF = Bytes.readByteArray(input);
             emptyKeyValueCFPtr = new 
ImmutableBytesPtr(Bytes.readByteArray(input));
             
    +        int numIndexedExpressions = WritableUtils.readVInt(input);
    --- End diff --
    
    Also, the removal of the indexedColumnsTypes will be a problem. You'll need 
to not do that plus do your new serialization based on the hacky way I 
mentioned (we should protobuf this at the next major release to give us more 
flexibility here).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to