Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/34#discussion_r23270696
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ---
    @@ -883,6 +903,14 @@ public void readFields(DataInput input) throws 
IOException {
             dataEmptyKeyValueCF = Bytes.readByteArray(input);
             emptyKeyValueCFPtr = new 
ImmutableBytesPtr(Bytes.readByteArray(input));
             
    +        int numIndexedExpressions = WritableUtils.readVInt(input);
    --- End diff --
    
    I added indexedColumnTypes back and used the sign of the length of 
emptyKeyValueCFPtr to differentiate between old and new clients. 
    IndexMaintainer has changed quite a lot, If an old client is talking to a 
server that has been upgraded, will I have to maintain the old behavior? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to