[ 
https://issues.apache.org/jira/browse/PHOENIX-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362303#comment-14362303
 ] 

ASF GitHub Bot commented on PHOENIX-1287:
-----------------------------------------

GitHub user shuxiong opened a pull request:

    https://github.com/apache/phoenix/pull/46

    Draft for PHOENIX-1287 subtask, ByteBasedLikeExpression

    Hi @JamesRTaylor ,
    
    This is a draft for
    1. Abstraction for Regex Engine, byte-based one(JONI) and string-based 
one(j.u.regex)
    2. ByteBasedLikeExpression and StringBasedLikeExpression based on 1.
    
    Comment if you think there is anything to be improved.
    Then I will work on other expressions(RegexpReplaceFunction, 
RegexpSplitFunction, RegexpSubstrFunction) next.
    
    Thanks.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shuxiong/phoenix 4.3-PHOENIX-1287

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #46
    
----
commit c96a34644eeb2d8769f9978aa5a28afd77f4c3c4
Author: yesx <[email protected]>
Date:   2015-03-15T07:34:32Z

    PHOENIX-1287 add ByteBased options in QueryServices; add lib dependency
    for JONI

commit 740f53d0cdf28300bf94c0a197245874d58005da
Author: yesx <[email protected]>
Date:   2015-03-15T08:12:55Z

    PHOENIX-1287 add AbstractBase Pattern and Matcher, JONI-based and 
Java-based; Add new types, ByteBasedLikeExpression and StringBasedLikeExpression

----


> Use the joni byte[] regex engine in place of j.u.regex
> ------------------------------------------------------
>
>                 Key: PHOENIX-1287
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1287
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>              Labels: gsoc2015
>
> See HBASE-11907. We'd get a 2x perf benefit plus it's driven off of byte[] 
> instead of strings.Thanks for the pointer, [~apurtell].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to