[ 
https://issues.apache.org/jira/browse/PHOENIX-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367231#comment-14367231
 ] 

ASF GitHub Bot commented on PHOENIX-1287:
-----------------------------------------

Github user shuxiong commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/46#discussion_r26670082
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/expression/LikeExpression.java ---
    @@ -289,8 +288,11 @@ public boolean evaluate(Tuple tuple, 
ImmutableBytesWritable ptr) {
                 return true;
             }
     
    -        String value = (String) PVarchar.INSTANCE.toObject(ptr, 
getStrExpression().getSortOrder());
    -        boolean matched = pattern.matcher(value).matches();
    +        String value = null;
    +        if (logger.isDebugEnabled()) {
    +            value = (String) PVarchar.INSTANCE.toObject(ptr, 
getStrExpression().getSortOrder());
    --- End diff --
    
    1. The original code has debugging lines, so I try to remains them. We just 
turn ptr into String when debugs.
    2. I don't quite understand what "rename getStrExpression()" means here?


> Use the joni byte[] regex engine in place of j.u.regex
> ------------------------------------------------------
>
>                 Key: PHOENIX-1287
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1287
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Shuxiong Ye
>              Labels: gsoc2015
>
> See HBASE-11907. We'd get a 2x perf benefit plus it's driven off of byte[] 
> instead of strings.Thanks for the pointer, [~apurtell].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to