[
https://issues.apache.org/jira/browse/PHOENIX-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367475#comment-14367475
]
ASF GitHub Bot commented on PHOENIX-1287:
-----------------------------------------
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/46#discussion_r26684109
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/visitor/CloneExpressionVisitor.java
---
@@ -107,7 +109,9 @@ public Expression visitLeave(ComparisonExpression node,
List<Expression> l) {
@Override
public Expression visitLeave(LikeExpression node, List<Expression> l) {
- return Determinism.PER_INVOCATION.compareTo(node.getDeterminism())
> 0 ? node : new LikeExpression(l);
--- End diff --
No instanceof checks. Add an abstract clone method to LikeExpression and
call that here instead.
abstract public LikeExpression clone(List<Expression> children);
> Use the joni byte[] regex engine in place of j.u.regex
> ------------------------------------------------------
>
> Key: PHOENIX-1287
> URL: https://issues.apache.org/jira/browse/PHOENIX-1287
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Shuxiong Ye
> Labels: gsoc2015
>
> See HBASE-11907. We'd get a 2x perf benefit plus it's driven off of byte[]
> instead of strings.Thanks for the pointer, [~apurtell].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
