[
https://issues.apache.org/jira/browse/PHOENIX-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370706#comment-14370706
]
ASF GitHub Bot commented on PHOENIX-1287:
-----------------------------------------
GitHub user shuxiong reopened a pull request:
https://github.com/apache/phoenix/pull/46
Draft for PHOENIX-1287 subtask, ByteBasedLikeExpression
Hi @JamesRTaylor ,
This is a draft for
1. Abstraction for Regex Engine, byte-based one(JONI) and string-based
one(j.u.regex)
2. ByteBasedLikeExpression and StringBasedLikeExpression based on 1.
Comment if you think there is anything to be improved.
Then I will work on other expressions(RegexpReplaceFunction,
RegexpSplitFunction, RegexpSubstrFunction) next.
Thanks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shuxiong/phoenix 4.3-PHOENIX-1287
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/46.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #46
----
commit c96a34644eeb2d8769f9978aa5a28afd77f4c3c4
Author: yesx <[email protected]>
Date: 2015-03-15T07:34:32Z
PHOENIX-1287 add ByteBased options in QueryServices; add lib dependency
for JONI
commit 740f53d0cdf28300bf94c0a197245874d58005da
Author: yesx <[email protected]>
Date: 2015-03-15T08:12:55Z
PHOENIX-1287 add AbstractBase Pattern and Matcher, JONI-based and
Java-based; Add new types, ByteBasedLikeExpression and StringBasedLikeExpression
commit 0b7a124278da678ae4f61c44a7d44776a209ac00
Author: yesx <[email protected]>
Date: 2015-03-18T14:58:35Z
fix typo macher -> matcher
commit 79fcdd31f637c1a8b1bdae18a9fd8aac31df142f
Author: yesx <[email protected]>
Date: 2015-03-18T16:12:42Z
PHOENIX-1287 add Syntax.Java and remove RemoveQuoteMachine in
JONIRegexWrapper
commit 6ea81b85e5c44b9f13700a1b1dd0e5059709a215
Author: yesx <[email protected]>
Date: 2015-03-18T16:14:21Z
PHOENIX-1287 remove useless function isPatternStringNull in
AbstractBasePattern
commit 1904792ec6c9eca3f63577c31b77a0f728829a62
Author: yesx <[email protected]>
Date: 2015-03-20T02:10:08Z
PHOENIX-1287 remove RegexPatternFactory
commit 4dcac15ac1b60e8a6654ab1ec0be7f7e4dc37378
Author: yesx <[email protected]>
Date: 2015-03-20T02:51:25Z
PHOENIX-1287 add abstract method clone in LikeExpression
commit 91cb009277154ff5cf26c1c0475c3dde5d396efc
Author: yesx <[email protected]>
Date: 2015-03-20T02:54:38Z
remove isMatcherSourceStrNull in AbstractBasePattern
commit bbda02f5811f3c3d8afd3ba3a18cabb53e1fcd10
Author: yesx <[email protected]>
Date: 2015-03-20T03:00:10Z
lower logger level to trace in LikeExpression
commit 553d7a021e6960c3fe3ce35f70a569447415982c
Author: yesx <[email protected]>
Date: 2015-03-20T03:16:30Z
remove AbstractBaseMatcher
commit 491de4cb46d2d824ef61502f1fecbae1333d84ce
Author: yesx <[email protected]>
Date: 2015-03-20T03:31:49Z
add bytes matches interface to JONIRegex
commit 224219ba11a394dc07e1d7973c18e97ff39d0a1d
Author: yesx <[email protected]>
Date: 2015-03-20T03:53:32Z
remove Utils
----
> Use the joni byte[] regex engine in place of j.u.regex
> ------------------------------------------------------
>
> Key: PHOENIX-1287
> URL: https://issues.apache.org/jira/browse/PHOENIX-1287
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Shuxiong Ye
> Labels: gsoc2015
>
> See HBASE-11907. We'd get a 2x perf benefit plus it's driven off of byte[]
> instead of strings.Thanks for the pointer, [~apurtell].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
