Github user gabrielreid commented on the pull request:
https://github.com/apache/phoenix/pull/47#issuecomment-83401354
@naveenmadhire the added test cases look good, but it looks like your
most-recent commit also removed the integration test.
The integration test should include a test like before (basically checking
that the function works in a real use case), as well as checking that it works
when used as a filter, something like:
select * from table t where instr(t.value, 'test') > 5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
