Github user gabrielreid commented on the pull request:
https://github.com/apache/phoenix/pull/47#issuecomment-88218650
Looks good, and I think that the test cases cover what needs to be covered.
Could you rebase the patch on the master branch, and squash the commits
into a single commit? If you're not familiar with how to do this, just let me
know and I'll do it when I commit the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
