[
https://issues.apache.org/jira/browse/PHOENIX-1770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378496#comment-14378496
]
Gabriel Reid commented on PHOENIX-1770:
---------------------------------------
Looks like a good plan to do this change at least for psql, but if you're up
for adding in the changes for the other tools in bin that would be great.
One minor nit: the {{exit}} function in Python is just something added into the
global namespace by the site module, and shouldn't generally be used in
programs (according to the [relevant
docs|https://docs.python.org/2/library/constants.html]). Using sys.exit(...)
would be better.
> psql.py returns 0 even if an error has occurred
> -----------------------------------------------
>
> Key: PHOENIX-1770
> URL: https://issues.apache.org/jira/browse/PHOENIX-1770
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.3
> Reporter: Mark Tse
> Fix For: 4.3.1
>
> Attachments: PHOENIX-1770-psql.patch
>
>
> psql.py should exit with the return code provided by
> `subprocess.check_call(java_cmd, shell=True)`.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
