[ 
https://issues.apache.org/jira/browse/PHOENIX-1770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380177#comment-14380177
 ] 

Gabriel Reid commented on PHOENIX-1770:
---------------------------------------

Patch looks pretty good -- one thing I'm thinking that would be good is if 
*all* the calls to {{subprocess.call}} in performance.py get checked, instead 
of only the last one.

> psql.py returns 0 even if an error has occurred
> -----------------------------------------------
>
>                 Key: PHOENIX-1770
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1770
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.3
>            Reporter: Mark Tse
>             Fix For: 4.3.1
>
>         Attachments: PHOENIX-1770.patch
>
>
> psql.py should exit with the return code provided by 
> `subprocess.check_call(java_cmd, shell=True)`.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to