[
https://issues.apache.org/jira/browse/PHOENIX-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491768#comment-14491768
]
James Taylor commented on PHOENIX-1705:
---------------------------------------
Looks very good, [~Dumindux]. One very minor stylistic nit:
Instead of this:
{code}
if(sortOrder == SortOrder.ASC) {
Arrays.fill(newBytes, ptr.getLength(), maxLength,
StringUtil.SPACE_UTF8);
}
else {
Arrays.fill(newBytes, ptr.getLength(), maxLength,
StringUtil.INVERTED_SPACE_UTF8);
}
{code}
I'd prefer this:
{code}
Arrays.fill(newBytes, ptr.getLength(), maxLength,
sortOrder == SortOrder.ASC ? StringUtil.SPACE_UTF8 :
StringUtil.INVERTED_SPACE_UTF8);
{code}
[~ramkrishna] - would you mind reviewing? Can you check the logic and tests
around transitioning from a short to an int for the offsets too, please?
> implement ARRAY_APPEND built in function
> ----------------------------------------
>
> Key: PHOENIX-1705
> URL: https://issues.apache.org/jira/browse/PHOENIX-1705
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Dumindu Buddhika
> Assignee: Dumindu Buddhika
> Attachments:
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function1.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function10.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function11.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function12.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function2.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function3.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function4.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function5.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function6.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function7.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function8.patch,
> PHOENIX-1705_implement_ARRAY_APPEND_built_in_function9.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
