Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/74#issuecomment-100526094
This is looking good, @nmaillard. Still some copy/paste code that we should
aim to cleanup. Also, take care that no exceptions are swallowed. Wrap checked
exceptions in a SQLException if it's declared in the method and otherwise wrap
in a RuntimeException and throw it. Also, make sure to remove or convert all
System.out.println calls to logging instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
