Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32848076
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -135,10 +155,8 @@ public synchronized boolean shouldStop() {
return shouldStop;
}
- public synchronized void stop() {
- this.shouldStop = true;
- }
-
+ // Convenience method for testing.
+ @SuppressWarnings("unused")
public synchronized long getRowCount() {
--- End diff --
No extra synchronization needed here because rowCount is already
AtomicLong. Unless the intent is to not let shouldStop, rowCount, isRunning get
modified concurrently since you are guarding accesses to them by doing
synchronizing on "this" .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
