Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32848343
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/DataModelResult.java
---
@@ -18,61 +18,57 @@
package org.apache.phoenix.pherf.result;
-import java.util.ArrayList;
-import java.util.List;
+import org.apache.phoenix.pherf.configuration.DataModel;
import javax.xml.bind.annotation.XmlAttribute;
import javax.xml.bind.annotation.XmlRootElement;
+import java.util.ArrayList;
+import java.util.List;
-import org.apache.phoenix.pherf.configuration.DataModel;
+@XmlRootElement(namespace = "org.apache.phoenix.pherf.result") public
class DataModelResult
+ extends DataModel {
+ private List<ScenarioResult> scenarioResult = new
ArrayList<ScenarioResult>();
+ private String zookeeper;
-@XmlRootElement(namespace = "org.apache.phoenix.pherf.result")
-public class DataModelResult extends DataModel {
- private List<ScenarioResult> scenarioResult = new
ArrayList<ScenarioResult>();
- private String zookeeper;
+ public List<ScenarioResult> getScenarioResult() {
+ return scenarioResult;
+ }
- public List<ScenarioResult> getScenarioResult() {
- return scenarioResult;
- }
+ @SuppressWarnings("unused") public void
setScenarioResult(List<ScenarioResult> scenarioResult) {
--- End diff --
Same comment about using SuppressWarnings("unused") here. I would remove
the method and make scenarioResult final.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
