Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32849281
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/RunTime.java ---
@@ -18,104 +18,91 @@
package org.apache.phoenix.pherf.result;
+import javax.xml.bind.annotation.XmlAttribute;
import java.util.Comparator;
import java.util.Date;
-import javax.xml.bind.annotation.XmlAttribute;
-
public class RunTime implements Comparator<RunTime>, Comparable<RunTime> {
- private Date startTime;
- private Integer elapsedDurationInMs;
- private String message;
- private Long resultRowCount;
- private String explainPlan;
-
- @SuppressWarnings("unused")
- public RunTime() {
- }
-
- @SuppressWarnings("unused")
- public RunTime(Integer elapsedDurationInMs) {
- this(null, elapsedDurationInMs);
- }
-
- public RunTime(Long resultRowCount, Integer elapsedDurationInMs) {
- this(null, resultRowCount, elapsedDurationInMs);
- }
-
- public RunTime(Date startTime, Long resultRowCount, Integer
elapsedDurationInMs) {
- this(null, null, startTime, resultRowCount,
elapsedDurationInMs);
- }
-
- public RunTime(String message, Date startTime, Long resultRowCount,
Integer elapsedDurationInMs) {
- this(message, null, startTime, resultRowCount,
elapsedDurationInMs);
- }
-
- public RunTime(String message, String explainPlan, Date startTime, Long
resultRowCount, Integer elapsedDurationInMs) {
- this.elapsedDurationInMs = elapsedDurationInMs;
- this.startTime = startTime;
- this.resultRowCount = resultRowCount;
- this.message = message;
- this.explainPlan = explainPlan;
- }
-
- @XmlAttribute()
- public Date getStartTime() {
- return startTime;
- }
-
- @SuppressWarnings("unused")
- public void setStartTime(Date startTime) {
- this.startTime = startTime;
- }
-
- @XmlAttribute()
- public Integer getElapsedDurationInMs() {
- return elapsedDurationInMs;
- }
-
- @SuppressWarnings("unused")
- public void setElapsedDurationInMs(Integer elapsedDurationInMs) {
- this.elapsedDurationInMs = elapsedDurationInMs;
- }
-
- @Override
- public int compare(RunTime r1, RunTime r2) {
- return
r1.getElapsedDurationInMs().compareTo(r2.getElapsedDurationInMs());
- }
-
- @Override
- public int compareTo(RunTime o) {
- return compare(this, o);
- }
-
- @XmlAttribute()
- public String getMessage() {
- return message;
- }
-
- @SuppressWarnings("unused")
- public void setMessage(String message) {
- this.message = message;
- }
-
- @XmlAttribute()
- public String getExplainPlan() {
- return explainPlan;
- }
-
- @SuppressWarnings("unused")
- public void setExplainPlan(String explainPlan) {
- this.explainPlan = explainPlan;
- }
-
- @XmlAttribute()
- public Long getResultRowCount() {
- return resultRowCount;
- }
-
- @SuppressWarnings("unused")
- public void setResultRowCount(Long resultRowCount) {
- this.resultRowCount = resultRowCount;
- }
+ private Date startTime;
--- End diff --
Unless XML bindings need them. In that case I would remove the
suppressedwarnings annotations from the setter methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
