[
https://issues.apache.org/jira/browse/PHOENIX-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611464#comment-14611464
]
maghamravikiran commented on PHOENIX-2088:
------------------------------------------
[~jmahonin] I didn't realize we were using the ColumnInfoEncoderDecoder within
the spark module. Thanks for bringing it up.
Apparently,the class was created to avoid making multiple calls to
PhoenixRuntime.generateColumnInfo for a given table and columns. In PigLoader,
we were calling from two places, one in PhoenixPigSchemaUtil and the other in
SqlQueryToColumnInfoFunction. To avoid calling generateColumnInfo, I had
serialized it the ColumnInfo and stored as a string within Configuration.
I will run few MR jobs on a cluster to confirm we don't see any issues with
removing the class. We can work together to fix this issue.
> Prevent splitting and recombining select expressions for MR integration
> -----------------------------------------------------------------------
>
> Key: PHOENIX-2088
> URL: https://issues.apache.org/jira/browse/PHOENIX-2088
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: maghamravikiran
> Attachments: PHOENIX-2088-wip.patch
>
>
> We currently send in the select expressions for the MR integration with a
> delimiter separated string, split based on the delimiter, and then recombine
> again using a comma separator. This is problematic because the delimiter
> character may appear in a select expression, thus breaking this logic.
> Instead, we should use a comma as the delimiter and avoid splitting and
> recombining as it's not necessary in that case. Instead, the entire string
> can be used as-is in that case to form the select expressions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
