[ https://issues.apache.org/jira/browse/PHOENIX-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613488#comment-14613488 ]
James Taylor commented on PHOENIX-2088: --------------------------------------- Thanks, [~maghamravikiran]. LGTM. So this patch doesn't serialize the List<ColumnInfo> as a String anymore, so no need for a separator character? I couldn't quite tell *how* it does get the List<ColumnInfo>. What's the new mechanism? > Prevent splitting and recombining select expressions for MR integration > ----------------------------------------------------------------------- > > Key: PHOENIX-2088 > URL: https://issues.apache.org/jira/browse/PHOENIX-2088 > Project: Phoenix > Issue Type: Bug > Reporter: James Taylor > Assignee: maghamravikiran > Attachments: PHOENIX-2088-pig.patch, PHOENIX-2088-wip-v2.patch, > PHOENIX-2088-wip.patch > > > We currently send in the select expressions for the MR integration with a > delimiter separated string, split based on the delimiter, and then recombine > again using a comma separator. This is problematic because the delimiter > character may appear in a select expression, thus breaking this logic. > Instead, we should use a comma as the delimiter and avoid splitting and > recombining as it's not necessary in that case. Instead, the entire string > can be used as-is in that case to form the select expressions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)