[ 
https://issues.apache.org/jira/browse/PHOENIX-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621804#comment-14621804
 ] 

ASF GitHub Bot commented on PHOENIX-2098:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/98#discussion_r34330056
  
    --- Diff: 
phoenix-pig/src/it/java/org/apache/phoenix/pig/udf/ReserveNSequenceTestIT.java 
---
    @@ -0,0 +1,284 @@
    +/**
    + * 
    + */
    +package org.apache.phoenix.pig.udf;
    +
    +import static org.apache.phoenix.query.BaseTest.setUpConfigForMiniCluster;
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertTrue;
    +
    +import java.io.IOException;
    +import java.sql.Connection;
    +import java.sql.DriverManager;
    +import java.sql.ResultSet;
    +import java.sql.SQLException;
    +import java.util.Properties;
    +
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hbase.HBaseTestingUtility;
    +import org.apache.hadoop.hbase.HConstants;
    +import org.apache.phoenix.end2end.NeedsOwnMiniClusterTest;
    +import org.apache.phoenix.jdbc.PhoenixDriver;
    +import org.apache.phoenix.util.PhoenixRuntime;
    +import org.apache.phoenix.util.PropertiesUtil;
    +import org.apache.phoenix.util.TestUtil;
    +import org.apache.pig.data.Tuple;
    +import org.apache.pig.data.TupleFactory;
    +import org.apache.pig.impl.util.UDFContext;
    +import org.junit.After;
    +import org.junit.AfterClass;
    +import org.junit.Before;
    +import org.junit.BeforeClass;
    +import org.junit.Rule;
    +import org.junit.Test;
    +import org.junit.experimental.categories.Category;
    +import org.junit.rules.ExpectedException;
    +
    +/**
    + * Test class to run all the Pig Sequence UDF integration tests against a 
virtual map reduce cluster.
    + */
    +@Category(NeedsOwnMiniClusterTest.class)
    +public class ReserveNSequenceTestIT {
    --- End diff --
    
    Minor item: please take at Ravi's latest changes for BaseHBaseManagedTimeIT 
[here](https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=984e62223c8aa507e9c044cecfc7fc92ffa42522).
 It'd be good if you did that as well - it's easier to manage tests that derive 
from our base classes as the framework changes. Also, they run faster if you 
don't need to spin up your own cluster for each test.


> Pig Udf that given a count Reserve chunks of numbers for a sequence
> -------------------------------------------------------------------
>
>                 Key: PHOENIX-2098
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2098
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Siddhi Mehta
>            Assignee: Siddhi Mehta
>
> Following up on the Jira to bulk reserve sequence's. PHOENIX-1954. 
> Adding a UDF to enable bulk reserve of sequence's from Pig



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to