[ 
https://issues.apache.org/jira/browse/PHOENIX-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621884#comment-14621884
 ] 

ASF GitHub Bot commented on PHOENIX-2098:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/98#discussion_r34332525
  
    --- Diff: 
phoenix-pig/src/main/java/org/apache/phoenix/pig/udf/ReserveNSequence.java ---
    @@ -0,0 +1,88 @@
    +/**
    + * 
    + */
    +package org.apache.phoenix.pig.udf;
    +
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license agreements. See the NOTICE
    + * file distributed with this work for additional information regarding 
copyright ownership. The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the "License"); you may 
not use this file except in compliance with the
    + * License. You may obtain a copy of the License at 
http://www.apache.org/licenses/LICENSE-2.0 Unless required by
    + * applicable law or agreed to in writing, software distributed under the 
License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied. See the License for the specific language
    + * governing permissions and limitations under the License.
    + */
    +import java.io.IOException;
    +import java.sql.Connection;
    +import java.sql.ResultSet;
    +import java.sql.SQLException;
    +
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hbase.HConstants;
    +import org.apache.phoenix.mapreduce.util.ConnectionUtil;
    +import org.apache.pig.EvalFunc;
    +import org.apache.pig.data.Tuple;
    +import org.apache.pig.impl.util.UDFContext;
    +
    +import com.google.common.base.Preconditions;
    +
    +/**
    + * UDF to Reserve a chunk of numbers for a given sequence
    + * 
    + * @note The way this UDF is invoked we open a new connection for every 
tuple row. The UDF will not perform well on
    --- End diff --
    
    Prashant would know if that's possible, I suspect, but I'm not sure (as 
you're definitely more of a Pig expert than me). @mravi may know too. It's not 
too bad from a Phoenix perspective, as we cache the underlying HConnection, so 
making a new connection (on the same JVM) is cheap.


> Pig Udf that given a count Reserve chunks of numbers for a sequence
> -------------------------------------------------------------------
>
>                 Key: PHOENIX-2098
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2098
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Siddhi Mehta
>            Assignee: Siddhi Mehta
>
> Following up on the Jira to bulk reserve sequence's. PHOENIX-1954. 
> Adding a UDF to enable bulk reserve of sequence's from Pig



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to