[ 
https://issues.apache.org/jira/browse/PHOENIX-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635789#comment-14635789
 ] 

Josh Mahonin commented on PHOENIX-2088:
---------------------------------------

[~tdsilva] The previous version of the patch 
(PHOENIX-2088-4.4-HBase-0.98.patch) had changes in 'DataFrameFunctions.scala' 
and 'ProductRDDFunctions.scala' to specifically instantiate a new Configuration 
and ColumnInfo metadata list on a per-partition basis, due to those classes not 
being serializable.

If this patch is reasonably close to finished and is working for mapreduce / 
pig, I can see about working your new changes into the spark plugin, though I 
don't think I'll be able to get to it for a day or two.

> Prevent splitting and recombining select expressions for MR integration
> -----------------------------------------------------------------------
>
>                 Key: PHOENIX-2088
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2088
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>         Attachments: PHOENIX-2088-4.4-HBase-0.98-v2.patch, 
> PHOENIX-2088-4.4-HBase-0.98.patch, PHOENIX-2088-pig.patch, 
> PHOENIX-2088-wip-v2.patch, PHOENIX-2088-wip-v3.patch, PHOENIX-2088-wip.patch
>
>
> We currently send in the select expressions for the MR integration with a 
> delimiter separated string, split based on the delimiter, and then recombine 
> again using a comma separator. This is problematic because the delimiter 
> character may appear in a select expression, thus breaking this logic. 
> Instead, we should use a comma as the delimiter and avoid splitting and 
> recombining as it's not necessary in that case. Instead, the entire string 
> can be used as-is in that case to form the select expressions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to