[ 
https://issues.apache.org/jira/browse/PHOENIX-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641299#comment-14641299
 ] 

ASF GitHub Bot commented on PHOENIX-1661:
-----------------------------------------

Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/101#discussion_r35477420
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/expression/JsonSubsetExpression.java
 ---
    @@ -0,0 +1,102 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.phoenix.expression;
    +
    +import java.util.Iterator;
    +import java.util.List;
    +
    +import org.apache.hadoop.hbase.io.ImmutableBytesWritable;
    +import org.apache.phoenix.expression.visitor.ExpressionVisitor;
    +import org.apache.phoenix.schema.json.PhoenixJson;
    +import org.apache.phoenix.schema.tuple.Tuple;
    +import org.apache.phoenix.schema.types.PBoolean;
    +import org.apache.phoenix.schema.types.PDataType;
    +import org.apache.phoenix.schema.types.PJson;
    +
    +public class JsonSubsetExpression extends BaseCompoundExpression{
    +   public JsonSubsetExpression(List<Expression> children) {
    +        super(children);
    +    }
    +   public JsonSubsetExpression() {  
    +    }
    +   @Override
    +   public boolean evaluate(Tuple tuple, ImmutableBytesWritable ptr) {
    +           if(children.get(1) instanceof BaseJSONExpression){
    +                   
if(((BaseJSONExpression)children.get(1)).getRealDataType()!=PJson.INSTANCE)
    +                   {
    +                           ptr.set(PDataType.FALSE_BYTES);
    +                           return true;
    +                   }
    +           }
    +           if (!children.get(1).evaluate(tuple, ptr)) {
    +            return false;
    +        }
    +           PhoenixJson pattern = (PhoenixJson) 
PJson.INSTANCE.toObject(ptr, children.get(1).getSortOrder());
    +           if(children.get(0) instanceof BaseJSONExpression){
    +                   
if(((BaseJSONExpression)children.get(0)).getRealDataType()!=PJson.INSTANCE)
    +                   {
    +                           ptr.set(PDataType.FALSE_BYTES);
    +                           return true;
    +                   }
    +           }
    +           if (!children.get(0).evaluate(tuple, ptr)) {
    +           return false;
    +       }
    +           PhoenixJson value = (PhoenixJson) PJson.INSTANCE.toObject(ptr, 
children.get(0).getSortOrder());
    +           //null value
    +           if(value==null){
    +                   ptr.set(PDataType.FALSE_BYTES);
    +                   return true;
    +           }
    +           //empty set
    +           if(pattern.getNodeSize()==0){
    +                   ptr.set(PDataType.TRUE_BYTES);
    +                   return true;
    +           }
    +           if(pattern.getNodeSize()>value.getNodeSize()){
    +                   ptr.set(PDataType.FALSE_BYTES);
    +                   return true;
    +           }
    +           Iterator<String> fildnames=pattern.getFieldNames();
    --- End diff --
    
    minor nit: typo


> Implement built-in functions for JSON
> -------------------------------------
>
>                 Key: PHOENIX-1661
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1661
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>              Labels: JSON, Java, SQL, gsoc2015, mentor
>         Attachments: PhoenixJSONSpecification-First-Draft.pdf
>
>
> Take a look at the JSON built-in functions that are implemented in Postgres 
> (http://www.postgresql.org/docs/9.3/static/functions-json.html) and implement 
> the same for Phoenix in Java following this guide: 
> http://phoenix-hbase.blogspot.com/2013/04/how-to-add-your-own-built-in-function.html
> Examples of functions include ARRAY_TO_JSON, ROW_TO_JSON, TO_JSON, etc. The 
> implementation of these built-in functions will be impacted by how JSON is 
> stored in Phoenix. See PHOENIX-628. An initial implementation could work off 
> of a simple text-based JSON representation and then when a native JSON type 
> is implemented, they could be reworked to be more efficient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to