[ 
https://issues.apache.org/jira/browse/PHOENIX-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649789#comment-14649789
 ] 

ASF GitHub Bot commented on PHOENIX-1661:
-----------------------------------------

Github user AakashPradeep commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/102#discussion_r36013361
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayToJsonFunctionIT.java 
---
    @@ -0,0 +1,150 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.end2end;
    +
    +import static org.apache.phoenix.util.TestUtil.ROW1;
    +import static org.apache.phoenix.util.TestUtil.TABLE_WITH_ARRAY;
    +import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES;
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertFalse;
    +import static org.junit.Assert.assertTrue;
    +
    +import java.sql.*;
    +import java.util.Properties;
    +import org.apache.phoenix.expression.function.ArrayToJsonFunction;
    +import org.apache.phoenix.query.BaseTest;
    +import org.apache.phoenix.util.PhoenixRuntime;
    +import org.apache.phoenix.util.PropertiesUtil;
    +import org.junit.Test;
    +
    +/**
    + * End to end test for {@link 
org.apache.phoenix.expression.function.ArrayToJsonFunction}.
    + *
    + */
    +public class ArrayToJsonFunctionIT extends BaseHBaseManagedTimeIT {
    +    private static final String TABLE_WITH_ALL_ARRAY_TYPES = 
"TABLE_WITH_ALL_ARRAY_TYPES";
    +
    +    @Test
    +    public void testArrayToJsonWithAllArrayTypes() throws Exception {
    +        // create the table
    +        createTableWithAllArrayTypes(getUrl());
    +
    +        Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
    +        Connection conn = DriverManager.getConnection(getUrl(), props);
    +        conn.setAutoCommit(false);
    +
    +        try{
    +            // populate the table with data
    +            PreparedStatement stmt =
    +                    conn.prepareStatement("UPSERT INTO "
    +                            + TABLE_WITH_ALL_ARRAY_TYPES
    +                            + "(pk, BOOLEAN_ARRAY, BYTE_ARRAY, 
DOUBLE_ARRAY, FLOAT_ARRAY, INT_ARRAY, LONG_ARRAY, SHORT_ARRAY, STRING_ARRAY)\n"
    +                            + "VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)");
    +
    +            stmt.setString(1, "valueOne");
    +
    +            // boolean array
    +            Array boolArray = conn.createArrayOf("BOOLEAN", new Boolean[] 
{ true,false });
    +            int boolIndex = 2;
    --- End diff --
    
    Please rename boolIndex as boolColumnIndex and so for other index variables.


> Implement built-in functions for JSON
> -------------------------------------
>
>                 Key: PHOENIX-1661
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1661
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Assignee: LeiWang
>              Labels: JSON, Java, SQL, gsoc2015, mentor
>         Attachments: PhoenixJSONSpecification-First-Draft.pdf
>
>
> Take a look at the JSON built-in functions that are implemented in Postgres 
> (http://www.postgresql.org/docs/9.3/static/functions-json.html) and implement 
> the same for Phoenix in Java following this guide: 
> http://phoenix-hbase.blogspot.com/2013/04/how-to-add-your-own-built-in-function.html
> Examples of functions include ARRAY_TO_JSON, ROW_TO_JSON, TO_JSON, etc. The 
> implementation of these built-in functions will be impacted by how JSON is 
> stored in Phoenix. See PHOENIX-628. An initial implementation could work off 
> of a simple text-based JSON representation and then when a native JSON type 
> is implemented, they could be reworked to be more efficient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to