Github user elilevine commented on the pull request:
https://github.com/apache/phoenix/pull/104#issuecomment-128866480
Yeah, I understand that the feature allows TENANT_ID on data tables to be a
different type. What I'm not sure about is how useful this feature would be in
real life if internally we are treating tenant ids as strings in connections
and system tables anyway. Why not just do the same for data tables, as well
(which is how it is now implemented)? As you mentioned, every type can be
converted to a string and users can do easily do that for data tables.
If we relax type constrains for data tables but not for metadata
tables/connections we are making the implementation of multi-tenancy in phoenix
internally inconsistent. Should be all or nothing IMHO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
