Github user elilevine commented on the pull request:
https://github.com/apache/phoenix/pull/104#issuecomment-129580603
Everything looks good in terms of code. Excellent work, @JeffreyLyonsD2L.
The only thing to figure out now is whether or not we should add the feature at
all. I agree that changing the schema of SYSTEM.* tables is off the table. So
do we allow the tenant id column in data tables to be of different type than in
metadata tables? It does not sit well with me and makes multi-tenancy seem
inconsistent IMHO, as I mentioned above, since tenant id is always passed in as
string to connections and is stored as such in system tables.
@JeffreyLyonsD2L, maybe you can shine some light on our use-case. You
mentioned that not having to do data conversion is a plus. In what way? Are you
starting with existing data and don't want to do data conversion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
