[
https://issues.apache.org/jira/browse/PHOENIX-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682274#comment-14682274
]
ASF GitHub Bot commented on PHOENIX-1673:
-----------------------------------------
Github user JeffreyLyonsD2L commented on the pull request:
https://github.com/apache/phoenix/pull/104#issuecomment-130012385
Thanks @elilevine, it has been a very interesting discussion for me to see
:)
With regards to the tests you mentioned earlier, I've added them to the
TenantIdTypeIT. Although in looking over the review, I saw I missed one of your
previous comments regarding testing tenant-specific indexes and sequences, so
I'll add some of those this afternoon.
I'm fairly new to committing to open source, so is there anything you need
from me organizationally or git-wise once the final code changes are in
(something like going through and resolving the conflicts, or rebasing)?
> Allow tenant ID to be of any integral data type
> -----------------------------------------------
>
> Key: PHOENIX-1673
> URL: https://issues.apache.org/jira/browse/PHOENIX-1673
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.3.0
> Reporter: Mark Tse
> Assignee: Jeffrey Lyons
> Labels: Newbie, multi-tenant
> Fix For: 4.4.1
>
>
> When creating multi-tenant tables and views, the column that identifies the
> tenant (first primary key column) must be of type 'VARCHAR' or 'CHAR'.
> It should be possible to relax this restriction to use any integral data
> type. The tenant ID from the connection property can be converted based on
> the data type of the first primary key column.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
