[ 
https://issues.apache.org/jira/browse/PHOENIX-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680716#comment-14680716
 ] 

ASF GitHub Bot commented on PHOENIX-1673:
-----------------------------------------

Github user JeffreyLyonsD2L commented on the pull request:

    https://github.com/apache/phoenix/pull/104#issuecomment-129597825
  
    Hey @elilevine, thanks and I appreciate the review, I've been learning a 
lot :)
    
    In terms of our use case, we have a pre-existing schema that we don't want 
to modify. For one, it would be a significant refactor to some of our other 
code in order to handle converting our existing TenantIds to strings. 
    
    The other issue is that we have a lot of traffic that is interacting with 
the cluster directly through HBase and not through Phoenix. For this reason we 
like having the TenantIds as fixed length, so that the rowkeys are easy and 
logical to parse.
    
    It also seems reasonable to me that if the TenantId is naturally a number 
instead of a name that it could be represented with one, instead of forcing a 
conversion to string when we store it.


> Allow tenant ID to be of any integral data type
> -----------------------------------------------
>
>                 Key: PHOENIX-1673
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1673
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.3.0
>            Reporter: Mark Tse
>              Labels: Newbie, multi-tenant
>             Fix For: 4.4.1
>
>
> When creating multi-tenant tables and views, the column that identifies the 
> tenant (first primary key column) must be of type 'VARCHAR' or 'CHAR'.
> It should be possible to relax this restriction to use any integral data 
> type. The tenant ID from the connection property can be converted based on 
> the data type of the first primary key column.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to