[ 
https://issues.apache.org/jira/browse/PHOENIX-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705606#comment-14705606
 ] 

ASF GitHub Bot commented on PHOENIX-2186:
-----------------------------------------

Github user ndimiduk commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/111#discussion_r37571771
  
    --- Diff: phoenix-tracing-webapp/pom.xml ---
    @@ -0,0 +1,173 @@
    +<?xml version='1.0'?>
    +  <!--
    +
    + Licensed to the Apache Software Foundation (ASF) under one
    + or more contributor license agreements.  See the NOTICE file
    + distributed with this work for additional information
    + regarding copyright ownership.  The ASF licenses this file
    + to you under the Apache License, Version 2.0 (the
    + "License"); you may not use this file except in compliance
    + with the License.  You may obtain a copy of the License at
    +
    +   http://www.apache.org/licenses/LICENSE-2.0
    +
    + Unless required by applicable law or agreed to in writing,
    + software distributed under the License is distributed on an
    + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + KIND, either express or implied.  See the License for the
    + specific language governing permissions and limitations
    + under the License.
    +
    +-->
    +
    +  <project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +    <modelVersion>4.0.0</modelVersion>
    +
    +    <parent>
    +      <groupId>org.apache.phoenix</groupId>
    +      <artifactId>phoenix</artifactId>
    +      <version>4.4.1-HBase-0.98-SNAPSHOT</version>
    +    </parent>
    +
    +    <artifactId>phoenix-tracing-webapp</artifactId>
    +    <name>Phoenix - Tracing Web Application</name>
    +    <description>Tracing web application will visualize the phoenix 
traces</description>
    +
    +    <properties>
    +       <top.dir>${project.basedir}/..</top.dir>
    +    </properties>
    +
    +    <dependencies>
    +      <dependency>
    +        <groupId>org.eclipse.jetty</groupId>
    +        <artifactId>jetty-server</artifactId>
    +        <!-- TODO : pick the same jetty version throughout the project -->
    +        <version>${jettyVersion}</version>
    +        <scope>provided</scope>
    +      </dependency>
    +      <dependency>
    +        <groupId>org.eclipse.jetty</groupId>
    +        <artifactId>jetty-webapp</artifactId>
    +        <!-- TODO : pick the same jetty version throughout the project -->
    +        <version>${jettyVersion}</version>
    +        <scope>provided</scope>
    +      </dependency>
    +      <dependency>
    +          <groupId>org.apache.hadoop</groupId>
    +          <artifactId>hadoop-common</artifactId>
    +          <scope>provided</scope>
    +        </dependency>
    +      <dependency>
    +        <groupId>org.apache.phoenix</groupId>
    +        <artifactId>phoenix-core</artifactId>
    +        <scope>provided</scope>
    +      </dependency>
    +      <dependency>
    +        <groupId>org.apache.hbase</groupId>
    +        <artifactId>hbase-common</artifactId>
    +        <scope>provided</scope>
    +      </dependency>
    +      <dependency>
    +        <groupId>commons-logging</groupId>
    +        <artifactId>commons-logging</artifactId>
    +        <scope>provided</scope>
    +      </dependency>
    +      <dependency>
    +        <groupId>org.codehaus.jackson</groupId>
    +        <artifactId>jackson-core-asl</artifactId>
    +        <scope>provided</scope>
    +      </dependency>
    +      <dependency>
    +        <groupId>org.codehaus.jackson</groupId>
    +        <artifactId>jackson-mapper-asl</artifactId>
    +        <scope>provided</scope>
    +      </dependency>
    +    </dependencies>
    +
    +    <build>
    +      <plugins>
    +        <plugin>
    +          <groupId>org.codehaus.mojo</groupId>
    +          <artifactId>build-helper-maven-plugin</artifactId>
    +        </plugin>
    +      <plugin>
    +        <artifactId>maven-antrun-plugin</artifactId>
    +        <version>1.7</version>
    +        <executions>
    +          <execution>
    +            <phase>generate-sources</phase>
    +            <configuration>
    +              <tasks>
    +                <ant antfile="src/build/build.xml"/>
    +              </tasks>
    +            </configuration>
    +            <goals>
    +              <goal>run</goal>
    +            </goals>
    +          </execution>
    +        </executions>
    +      </plugin>
    +        <plugin>
    +          <artifactId>maven-assembly-plugin</artifactId>
    +          <executions>
    +            <execution>
    +              <id>runnable</id>
    +              <phase>package</phase>
    +              <goals>
    +                <goal>single</goal>
    +              </goals>
    +              <configuration>
    +                <attach>true</attach>
    +                <archive>
    +                  <manifest>
    +                    <addClasspath>true</addClasspath>
    +                    
<mainClass>org.apache.phoenix.tracingwebapp.http.Main</mainClass>
    +                  </manifest>
    +                </archive>
    +                
<finalName>${project.artifactId}-${project.version}</finalName>
    +                <descriptors>
    +                  
<descriptor>src/build/trace-server-runnable.xml</descriptor>
    +                </descriptors>
    +              </configuration>
    +            </execution>
    +          </executions>
    +        </plugin>
    +        <!--plugin>
    --- End diff --
    
    all this commented stuff is uncommented by PR112? Will there be some merge 
that needs to happen between these two PRs?


> Creating backend services for the Phoenix Tracing Web App
> ---------------------------------------------------------
>
>                 Key: PHOENIX-2186
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2186
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Nishani 
>            Assignee: Nishani 
>
> This will include the following components.
> Main class 
> Pom file
> Launch script 
> Backend trace service API



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to