[ 
https://issues.apache.org/jira/browse/PHOENIX-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705615#comment-14705615
 ] 

ASF GitHub Bot commented on PHOENIX-2186:
-----------------------------------------

Github user ndimiduk commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/111#discussion_r37572197
  
    --- Diff: 
phoenix-tracing-webapp/src/main/java/org/apache/phoenix/tracingwebapp/http/EntityFactory.java
 ---
    @@ -0,0 +1,98 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to you under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.tracingwebapp.http;
    +
    +import java.sql.Connection;
    +import java.sql.PreparedStatement;
    +import java.sql.ResultSet;
    +import java.sql.ResultSetMetaData;
    +import java.sql.SQLException;
    +import java.util.ArrayList;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
    +
    +public class EntityFactory {
    --- End diff --
    
    What does this class do? A class-level javadoc will help make this clear.


> Creating backend services for the Phoenix Tracing Web App
> ---------------------------------------------------------
>
>                 Key: PHOENIX-2186
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2186
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Nishani 
>            Assignee: Nishani 
>
> This will include the following components.
> Main class 
> Pom file
> Launch script 
> Backend trace service API



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to